Keep Chat Completions reasoning out of eval prompt history - #265
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Keep Chat Completions reasoning out of eval prompt history#265sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep model-generated Chat Completions reasoning separate from the message list reported as the prompt actually queried.
ChatCompletionsSamplercurrently appendschoice.message.reasoningtomessage_listafter the API returns, then exposes that mutated list asactual_queried_message_list. HealthBench uses that field as the conversation passed to its grader before adding the final response, so reasoning can become an extra assistant turn that affects grading even though it was not part of the original prompt.Fixes #264.
Fix
The sampler now:
actual_queried_message_listequal to the messages sent to the API;response_textas before;reasoningfield separately inresponse_metadatafor diagnostics.Regression coverage
Adds tests verifying that:
The request payload, scoring logic, retry behavior, and final response extraction are unchanged.