Use local rank for Responses Triton CUDA binding - #274
Open
sylvesterkaczmarek wants to merge 3 commits into
Open
Use local rank for Responses Triton CUDA binding#274sylvesterkaczmarek wants to merge 3 commits into
sylvesterkaczmarek wants to merge 3 commits into
Conversation
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind the Responses API Triton backend to its node-local CUDA device instead of using global distributed rank as a device index.
This backend selects its device independently and does not call
gpt_oss.torch.utils.init_distributed(), so the local-rank correction in #267 does not cover it.Fixes #273.
Fix
RANKfor distributed identity and log prefixes;LOCAL_RANKfortorch.cuda.set_device()and the CUDA device object;RANKwhenLOCAL_RANKis absent, preserving existing single-node/custom-launch behavior.Regression coverage
Adds a CPU-only mocked regression with
RANK=5andLOCAL_RANK=1verifying that:cuda:1;No model loading, checkpoint format, inference math, or logging identity is otherwise changed.