Add missing pytest-asyncio to the test extra - #302
Open
AryantJadhav wants to merge 1 commit into
Open
Conversation
tests/gpt_oss/tools/simple_browser/test_backend.py marks four tests with `@pytest.mark.asyncio`, but pytest-asyncio was not in the `test` extra. Without the plugin pytest does not run async test functions -- it reports them as failures with "async def functions are not natively supported" and warns that `asyncio` is an unknown mark. So `pip install gpt-oss[test] && pytest` gave 4 failures out of the box, and the coverage protecting the You.com and Exa backends was never actually executing. With the plugin installed those four tests run and pass (7 passed, up from 3 passed / 4 failed). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds pytest-asyncio to the test extra so async tests run correctly.
Changes:
- Adds
pytest-asyncio>=0.24.0to test dependencies.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/gpt_oss/tools/simple_browser/test_backend.py marks four tests with
@pytest.mark.asyncio, but pytest-asyncio was not in thetestextra. Without the plugin pytest does not run async test functions -- it reports them as failures with "async def functions are not natively supported" and warns thatasynciois an unknown mark.So
pip install gpt-oss[test] && pytestgave 4 failures out of the box, and the coverage protecting the You.com and Exa backends was never actually executing.With the plugin installed those four tests run and pass (7 passed, up from 3 passed / 4 failed).