fix(sessions): reset compaction state on clear - #4865
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seratch
requested changes
Sep 7, 2026
seratch
left a comment
Member
There was a problem hiding this comment.
Can you resolve the conflicts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reset retained response-chain state after
OpenAIResponsesCompactionSession.clear_session()successfully clears the underlying history.The wrapper previously reset cached session items and
_deferred_response_id, but retained_response_idand_last_unstored_response_id. A laterprevious_response_idcompaction could therefore reuse a response chain belonging to history the caller explicitly erased.A successful clear now resets all three response-chain fields alongside the history caches. The reset occurs only after the underlying clear succeeds, preserving existing state if the backend clear fails.
Test plan
previous_response_idcompaction.uv run pytest -q tests/memory/test_openai_responses_compaction_session.py— 56 passed.git diff --check— passed.Fixes #4864.