Small fixes for reading the input files correctly and to the OpenAIFi…#1801
Merged
Conversation
robtinn
requested review from
emitchell-openai
and removed request for
emitchell-openai
MW-OAI
approved these changes
May 7, 2025
Contributor
MW-OAI
left a comment
MW-OAI
left a comment
There was a problem hiding this comment.
Top half is fine with these edits
Worth ensuring Qdrant can run properly or remove in full
Worth exploring FT of 4.1-nano to bring it to latest models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first of a few PRs I will do to update and extend the content in this cookbook example.
This PR will make some small fixes:
self.file_objectwait_for_finetuningmethod so it uses retrieve() instead of refresh() and exits on success, failure or job cancellation.Motivation
Some of these issues have been picked up in the GitHub issues and it will make the cookbook easier to run without users having to make several fixes.