docs: unify get weather function name in openai-harmony for consistency - #2048
Merged
Conversation
dkundel-openai
approved these changes
Aug 12, 2025
Contributor
Author
|
Hello @dkundel-openai, |
imran-binhasan
added a commit
to imran-binhasan/openai-cookbook
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request corrects an error in the tool-calling example where the function names used for invocation did not match the actual function name defined in the
toolssection.The tool was defined with the name
get_current_weather. However, the example code that demonstrated its usage was incorrectly usingget_weatherandlookup_weather, creating a discrepancy.This commit fixes the example code to consistently use the function name,
get_current_weather, throughout the entire request-response flow, aligning it with the existing tool definition.Motivation
The primary motivation for this change is to prevent confusion for anyone reading the code.
By this fix, a developer following this code will see a clear and logical flow, free from the ambiguity caused by mismatched names, making the learning process much smoother.