Align image eval OCR text with flyer prompt - #3000
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COFFEE_PROMPT.REQUIRED_TEXTwith the prompt's literal hyphenated strings.Motivation
The prompt explicitly requires these exact lines:
20% OFF - Mon-Thu123 Market St - 7am-6pmBut the OCR check currently expects bullet separators and en-dashes instead. Because
add_ocr_text_check()compares extracted lines by exact set equality, a flyer that follows the generation prompt perfectly can still be marked as missing the expected OCR text and containing extra text.The oracle should use the same literal strings as the task it is grading.
Validation
This changes only two entries in
REQUIRED_TEXT:Self-review
Maintainers may modify the branch if needed.