Validate realtime plot summary shape - #3006
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summary.jsonloaded by the realtime plotting CLI to contain a JSON object.Motivation
plot_eval_results.pycurrently accepts any syntactically valid JSON value and passes it directly tobuild_realtime_eval_plots(). A list, string, number, or other non-object JSON value therefore gets past the file-loading boundary and fails later inside plotting code that expects mapping-style summary data.The run summary contract is an object. Validating that shape immediately produces a clear error at the source instead of an unrelated downstream attribute/type failure.
Validation
summary.json-> existing plotting path unchangedJSONDecodeErrorbehavior unchangedValueErrornaming the summary fileSelf-review
Maintainers may modify the branch if needed.