Avoid duplicate guardrail metric history - #3007
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThresholdAdjuster.calculate_adjustment().update_metrics()behavior unchanged.Motivation
The feedback loop already records every evaluation result through
ThresholdAdjuster.update_metrics(): once after the initial eval and once after each subsequent eval.calculate_adjustment()then appends that sameGuardrailMetricsobject again before changing the threshold.As a result,
metrics_historycontains duplicate entries for every metric snapshot that triggers an adjustment. That makes the tuning history inaccurate for diagnostics or future consumers even though the current report's first/last metric lookup happens to mask the duplication.There is already one explicit method responsible for recording metric observations, so adjustment calculation should not record the same observation again.
Validation
update_metrics()update_metrics()Self-review
Maintainers may modify the branch if needed.