Diag/beds24 UI auth 20260822 - #3016
Open
elcidspain wants to merge 839 commits into
Open
Conversation
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
…b64 wait, support invite jagxI4-waqtit-cesseg
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
…sync [WIP] Run Beds24 photo vault sync after dispatcher update
…omment-again Verify Airtable upsert already prevents duplicate daily checkpoints
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
…nt-another-one
…tions-job-again
Co-authored-by: elcidspain <208400175+elcidspain@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a large set of operational/static-site assets and automations for the EL CID / AUMARA web properties (routing, staff PWA, Beds24-related tooling, probes, and GitHub Actions workflows), and also adds a PHENOMENA static site with a Pages deployment workflow, alongside repository governance docs for AI-assisted execution.
Changes:
- Adds static routing/redirect configuration and multiple new static-site/PWA assets (EL CID, AUMARA, staff).
- Introduces “AUMARA Control Tower” code, policies, evidence/checkpoints, and extensive GitHub Actions automation/probing for Beds24/Nominalia.
- Adds governance documentation and templates (AI execution policy / checkpoint protocol) and PHENOMENA site + Pages deploy workflow.
Reviewed changes
Copilot reviewed 181 out of 843 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| vercel.json | Adds Vercel routing rules for multiple static sub-sites. |
| staff/sw.js | Adds staff PWA service worker caching logic. |
| staff/planner23-unguard.js | Adds MutationObserver unguard shim. |
| staff/planner23-guard.js | Adds MutationObserver guard shim. |
| staff/manifest.webmanifest | Adds PWA manifest for staff app. |
| staff/icon.svg | Adds PWA icon asset. |
| staff/fix.html | Adds cache/service-worker reset page. |
| staff/bootfix231.js | Adds fetch timeout + boot/runtime patching. |
| SECURITY.md | Adds repository security policy document (template). |
| phenomena/site/index.html | Adds PHENOMENA landing page HTML. |
| phenomena/README.md | Adds PHENOMENA project description. |
| phenomena/PUBLISHING.md | Adds PHENOMENA publishing strategy doc. |
| ops/nominalia-secret-slots.json | Records Nominalia secret-slot presence (booleans). |
| ops/nominalia-secret-presence.json | Records variable presence (booleans). |
| ops/nominalia-login-form.json | Captures sanitized Nominalia login form contract. |
| ops/nominalia-control-probe.json | Records Nominalia control probe result. |
| ops/elcid-root-deploy.md | Records EL CID deployment evidence snapshot. |
| ops/elcid-production-probe.md | Records production probe results for EL CID/AUMARA/Beds24. |
| ops/aumara-domain-network-probe.md | Records AUMARA domain/network probe evidence. |
| ops/AUMARA_VOUCHERS_LIVE.md | Documents voucher generation/live state. |
| ops/AUMARA_FIRST_GUESTS_VOUCHER_10.md | Work order/details for first guest voucher drafts. |
| index.html | Adds root redirect to elcid-site/. |
| elcid-site/privacy.html | Adds privacy page (review text). |
| elcid-site/legal.html | Adds legal notice page (review text). |
| elcid-site/cookies.html | Adds cookies page (review text). |
| elcid-site/CONTENT_BASELINE.md | Adds content baseline + production blockers checklist. |
| elcid-site/AGENT_BRIEF.md | Adds recovery brief and non-negotiable guardrails. |
| elcid-site/.production-release-v2 | Adds production release trigger marker file. |
| elcid-site/.deploy-release-2026-07-14 | Adds deployment release note marker. |
| docs/CNAME | Sets custom domain for GitHub Pages docs site. |
| docs/CHECKPOINT_PROTOCOL.md | Adds checkpoint protocol documentation. |
| docs/AI_EXECUTION_POLICY.md | Adds AI execution policy documentation. |
| diagnostics/nominalia-ftp.txt | Adds Nominalia FTP diagnostics evidence. |
| diagnostics/nominalia-deploy-status.txt | Adds Nominalia deploy status evidence. |
| aumara-site/video-preview.html | Adds redirect helper to /aumara/#explore. |
| aumara-site/snapshots/live-2026-07-14/SNAPSHOT.md | Adds snapshot metadata/evidence doc. |
| aumara-site/scripts/build_walkthrough_nodes.sh | Adds ffmpeg node clip builder script. |
| aumara-site/script.js | Adds smooth-scroll anchor behavior. |
| aumara-site/route-v01.json | Adds walkthrough route metadata. |
| aumara-site/README.md | Adds AUMARA site README and release checklist. |
| aumara-site/PUBLISHING.md | Adds AUMARA publishing/deploy notes. |
| aumara-site/map.html | Adds redirect helper to /aumara/#explore. |
| aumara-site/EXECUTION_STATUS_2026-08-03.md | Adds execution status doc. |
| aumara-site/docs/media-ingest-2026-07-10.md | Adds media ingest inventory doc. |
| aumara-site/direct-v2.html | Adds redirect wrapper to direct-v3-preview.html. |
| aumara-site/deploy-checkpoint-explore-v1.txt | Adds explore deploy checkpoint note. |
| aumara-site/creative/output_images/README.md | Documents generated-artifact output directory. |
| aumara-site/creative/.gitignore | Ignores generated creative outputs. |
| aumara-site/content/AUMARA_Rates_Stay_Format_Pack_v01.md | Adds rates/stay-format pack doc. |
| aumara-site/aumara-site/direct-v3-preview.html | Adds Pages redirect shim for AUMARA preview. |
| aumara-site/AI_OPS_RESPONSE.md | Adds ops response / reconciliation doc. |
| aumara-control-tower/video/animate_photo_ffmpeg.sh | Adds photo-to-video ffmpeg utility. |
| aumara-control-tower/vendor/beds24-openapi-discovery.json | Adds Beds24 OpenAPI discovery evidence. |
| aumara-control-tower/tests/test_guest_reply_policy_runtime.py | Adds unit tests for guest-reply runtime. |
| aumara-control-tower/tests/test_beds24_photo_sync_discovery_workflow.py | Adds tests for Beds24 photo sync workflow expectations. |
| aumara-control-tower/systems/ttlock-lock-registry.md | Adds TTLock lock registry doc. |
| aumara-control-tower/systems/aumara-fixed-guest-pin.md | Adds fixed guest PIN operating-mode doc. |
| aumara-control-tower/src/send-test-email.mjs | Adds manual test email sender. |
| aumara-control-tower/src/message-template.mjs | Adds guest access email template + HTML escaping. |
| aumara-control-tower/src/mailer.mjs | Adds Resend mailer client + live-send guards. |
| aumara-control-tower/src/idempotency.mjs | Adds idempotency key derivation + in-memory store. |
| aumara-control-tower/src/healthcheck.mjs | Adds Resend domain-list healthcheck. |
| aumara-control-tower/scripts/tests/test_eposnow_reporting_export.py | Adds EPOSNow export tests. |
| aumara-control-tower/scripts/tests/test_beds24_elcid_auto_replies.py | Adds Beds24 reply audit tests (no-send). |
| aumara-control-tower/scripts/tests/test_beds24_aumara_voucher_autogen.py | Adds voucher autogen tests. |
| aumara-control-tower/scripts/tests/test_beds24_aumara_voucher_activate.py | Adds voucher activate tests. |
| aumara-control-tower/policies/registry.yaml | Adds policy registry index (JSON-compatible YAML). |
| aumara-control-tower/policies/README.md | Documents policy registry structure and validation. |
| aumara-control-tower/policies/guest_reply_runtime.json | Adds EL CID guest-reply snapshot pin. |
| aumara-control-tower/policies/guest_journey_runtime.json | Adds dual-property guest-journey snapshot pin. |
| aumara-control-tower/policies/elcid-direct-guest-notes.json | Adds verified EL CID direct guest note policy. |
| aumara-control-tower/policies/elcid-bed-nonsmoking.json | Adds combined bed/non-smoking note policy. |
| aumara-control-tower/policies/CHANGELOG.md | Adds policy registry changelog. |
| aumara-control-tower/policies/aumara-poststay-followup.json | Adds AUMARA post-stay followup policy. |
| aumara-control-tower/packets/2026-07-06-nominalia-deployment.md | Adds Nominalia deployment packet doc. |
| aumara-control-tower/packets/2026-07-06-execution-status.md | Adds execution status packet doc. |
| aumara-control-tower/packets/2026-07-06-beds24-cutover.md | Adds Beds24 cutover packet doc. |
| aumara-control-tower/package.json | Adds Node package manifest for control tower. |
| aumara-control-tower/fixtures/guest-service-journey.json | Adds synthetic guest-service journey fixture. |
| aumara-control-tower/fixtures/guest-request-dry-run.json | Adds anonymized CI fixture for guest requests. |
| aumara-control-tower/fixtures/daily-ops/gmail.json | Adds synthetic daily ops Gmail fixture. |
| aumara-control-tower/fixtures/daily-ops/epos/tenders.csv | Adds synthetic EPOS tenders fixture. |
| aumara-control-tower/fixtures/daily-ops/epos/manifest.json | Adds synthetic EPOS manifest fixture. |
| aumara-control-tower/fixtures/daily-ops/beds24.json | Adds synthetic Beds24 daily summary fixture. |
| aumara-control-tower/fixtures/daily-ops/b24.json | Adds synthetic task-status fixture. |
| aumara-control-tower/evidence/secret-anchor-presence.json | Adds secret-anchor presence evidence. |
| aumara-control-tower/evidence/beds24-v2-picture-structure/32100194895-started.json | Adds Beds24 picture-structure run evidence. |
| aumara-control-tower/evidence/beds24-ui-session/status.json | Adds Beds24 UI session status evidence. |
| aumara-control-tower/evidence/beds24-ui-session/public.pem | Adds Beds24 UI session public key. |
| aumara-control-tower/evidence/beds24-ui-handshake/state.json | Adds Beds24 UI handshake state evidence. |
| aumara-control-tower/evidence/beds24-ui-handshake/public.pem | Adds Beds24 UI handshake public key. |
| aumara-control-tower/evidence/beds24-ui-handshake/password.enc | Adds encrypted handshake payload artifact. |
| aumara-control-tower/evidence/beds24-token-recovery/32100728804.json | Adds Beds24 token recovery evidence. |
| aumara-control-tower/evidence/beds24-token-auth-status.json | Adds Beds24 token auth status evidence. |
| aumara-control-tower/evidence/beds24-source-job-matches.txt | Adds workflow log match evidence. |
| aumara-control-tower/evidence/beds24-secret-presence.json | Adds Beds24 secret presence evidence. |
| aumara-control-tower/evidence/beds24-refresh-vault.json | Adds encrypted refresh vault blob evidence. |
| aumara-control-tower/evidence/beds24-production-auth/32100461222.json | Adds production auth probe evidence. |
| aumara-control-tower/evidence/beds24-photo-sync-last.json | Adds last photo sync status evidence. |
| aumara-control-tower/evidence/beds24-live-artifact-recovery.json | Adds live artifact recovery evidence. |
| aumara-control-tower/evidence/beds24-legacy-probe/32099742935/status.json | Adds legacy probe status evidence. |
| aumara-control-tower/evidence/beds24-legacy-probe/32099742935/public.pem | Adds legacy probe public key. |
| aumara-control-tower/evidence/beds24-legacy-probe/32099742935/login_payload.b64 | Adds placeholder legacy login payload marker. |
| aumara-control-tower/evidence/beds24-legacy-probe/32099692814/status.json | Adds legacy probe waiting status evidence. |
| aumara-control-tower/evidence/beds24-legacy-probe/32099692814/public.pem | Adds legacy probe public key. |
| aumara-control-tower/evidence/beds24-historical-invite/32100854181.json | Adds historical invite recovery evidence. |
| aumara-control-tower/evidence/beds24-finalize-status.json | Adds finalize status evidence. |
| aumara-control-tower/evidence/beds24-execution-log.txt | Adds one-line execution log evidence. |
| aumara-control-tower/evidence/beds24-exchange/latest.json | Adds Beds24 exchange status summary. |
| aumara-control-tower/evidence/beds24-exchange-artifact-recovery.json | Adds exchange artifact recovery evidence. |
| aumara-control-tower/evidence/beds24-credential-shape.json | Adds credential shape evidence (lengths/flags). |
| aumara-control-tower/evidence/beds24-booking-id-recovery-diagnostic.json | Adds booking-id recovery diagnostic evidence. |
| aumara-control-tower/evidence/beds24-booking-bridge-status.json | Adds booking-bridge status evidence. |
| aumara-control-tower/evidence/beds24-auth-bootstrap-status.json | Adds auth bootstrap status evidence. |
| aumara-control-tower/evidence/beds24-account-scope-probe.json | Adds account scope probe evidence. |
| aumara-control-tower/docs/ttlock-gateway-mesh-v01.md | Adds TTLock gateway mesh plan doc. |
| aumara-control-tower/docs/aumara-poststay-feedback-v1.md | Adds post-stay feedback flow doc. |
| aumara-control-tower/config/copilot-mcp.json | Adds MCP configuration for local tooling. |
| aumara-control-tower/checkpoints/BEDS24_V1_CONTENT_SHAPE.json | Adds Beds24 v1 content shape checkpoint. |
| aumara-control-tower/checkpoints/BEDS24_PHOTO_SYNC_DISCOVERY.json | Adds Beds24 photo sync discovery checkpoint. |
| aumara-control-tower/checkpoints/BEDS24_BINDING_INVENTORY.json | Adds secret/var name inventory checkpoint. |
| aumara-control-tower/checkpoints/AUMARA_CONTENT_TEAM_STATE.json | Adds content team state checkpoint. |
| aumara-control-tower/checkpoints/AUMARA_AGENT_CONNECTIVITY_RECEIPT.json | Adds connectivity receipt checkpoint. |
| aumara-control-tower/checkpoints/AUMARA_ACTIONS_HEARTBEAT.json | Adds Actions heartbeat checkpoint. |
| aumara-control-tower/checkpoints/2026-08-17-guest-service-journey-v1.md | Adds guest-service journey checkpoint. |
| aumara-control-tower/checkpoints/2026-08-17-aumara-live-canary-v1.md | Adds live canary checkpoint doc. |
| aumara-control-tower/checkpoints/2026-08-02-continuous-beds24-note-writer.md | Adds continuous note-writer checkpoint doc. |
| aumara-control-tower/beds24-requests/AUMARA-MEDINA-20260718-660.json | Adds Beds24 request payload artifact. |
| aumara-control-tower/.env.example | Adds example env vars for control tower. |
| aumara_control_tower/scripts/init.py | Adds Python package shim for legacy scripts path. |
| aumara_control_tower/init.py | Adds Python package namespace init. |
| AGENTS.md | Adds AI execution governance section to agent guidance. |
| .secure/nominalia-password-31894675037.enc | Adds encrypted Nominalia password blob. |
| .secure/nominalia-password-31894570722.enc | Adds encrypted Nominalia password blob (second). |
| .secure/nominalia-live-31894675037.pub | Adds public key for Nominalia live secret. |
| .secure/nominalia-live-31894570722.pub | Adds public key for Nominalia live secret. |
| .gitignore | Ignores voucher evidence output directory. |
| .github/workflows/secret-anchor-probe.yml | Adds workflow to record boolean-only secret presence. |
| .github/workflows/probe-nominalia-secret-slots.yml | Adds workflow to probe secret-slot presence. |
| .github/workflows/probe-nominalia-secret-presence.yml | Adds workflow to probe variable presence. |
| .github/workflows/probe-nominalia-login-form.yml | Adds workflow to capture sanitized login form. |
| .github/workflows/policy-registry.yml | Adds workflow for policy registry validation. |
| .github/workflows/phenomena-pages.yml | Adds GitHub Pages deploy workflow for PHENOMENA. |
| .github/workflows/nominalia-live-domain-mutate.yml | Adds production DNS mutator workflow. |
| .github/workflows/nominalia-live-domain-mutate-email.yml | Adds variant DNS mutator with login mutation step. |
| .github/workflows/elcid-site-check.yml | Adds EL CID static checks workflow. |
| .github/workflows/build-website.yaml | Makes deploy hook optional when secret missing. |
| .github/workflows/beds24-ui-handshake-init.yml | Adds Beds24 UI encrypted handshake init workflow. |
| .github/workflows/beds24-ui-handshake-init.trigger | Adds trigger file for Beds24 UI handshake init. |
| .github/workflows/beds24-secret-probe.yml | Adds Beds24 secret presence probe workflow. |
| .github/workflows/beds24-photo-sync-vault-run.yml | Adds vault-based Beds24 photo sync workflow. |
| .github/workflows/beds24-photo-sync-vault-run.trigger | Adds trigger file for photo sync run. |
| .github/workflows/beds24-photo-sync-vault-controller.yml | Adds controller workflow for photo vault sync. |
| .github/workflows/beds24-live-recovery-dispatch-controller.yml | Adds issue-driven dispatcher to run workflows. |
| .github/workflows/beds24-finance-snapshot.yml | Adds read-only finance snapshot workflow. |
| .github/workflows/beds24-elcid-studio-audit.yml | Adds Studio audit workflow (manual). |
| .github/workflows/beds24-elcid-auto-replies.yml | Adds no-send auto-reply audit workflow. |
| .github/workflows/beds24-binding-inventory.yml | Adds scheduled secrets/vars name inventory workflow. |
| .github/workflows/beds24-auth-check.yml | Adds deterministic auth-check workflow + evidence upload. |
| .github/workflows/beds24-aumara-fixed-pin-seed.yml | Adds fixed PIN seeding workflow. |
| .github/workflows/beds24-aumara-booking.yml | Adds retired legacy bridge placeholder workflow. |
| .github/workflows/beds24-aumara-booking-v2.yml | Adds legacy bridge safety workflow (dry-run). |
| .github/workflows/beds24-aumara-access-message-send.yml | Adds access message send/audit workflow. |
| .github/workflows/aumara-webhook-safety.yml | Adds webhook safety workflow (fail-closed). |
| .github/workflows/aumara-walkthrough-preview.yml | Adds walkthrough preview build workflow. |
| .github/workflows/aumara-voucher-autogen.yml | Adds voucher generation workflow. |
| .github/workflows/aumara-voucher-activate.yml | Adds voucher activation workflow. |
| .github/workflows/aumara-visual-pack.yml | Adds visual pack generation workflow using OpenAI API. |
| .github/workflows/aumara-validate.yml | Adds validation workflow for creative prompts/scripts. |
| .github/workflows/aumara-feedback-validate.yml | Adds validation workflow for post-stay feedback. |
| .github/workflows/aumara-actions-heartbeat.yml | Adds workflow to persist heartbeat checkpoint. |
| .github/pull_request_template.md | Adds execution contract section to PR template. |
| .github/copilot-instructions.md | Adds repo-specific Copilot instructions doc. |
| .github/aumara-beds24-sync.trigger | Adds trigger file for Beds24 sync. |
| .github/aumara-beds24-binding-inventory.trigger | Adds trigger file for binding inventory workflow. |
Suppressed comments (1)
aumara-control-tower/beds24-requests/AUMARA-MEDINA-20260718-660.json:22
- This request artifact includes real guest PII (email/phone) and repeats it inside free-text
comments/notes. Repo guidance inelcid-site/AGENT_BRIEF.mdexplicitly forbids committing guest data/credentials, so this needs to be redacted or replaced with a synthetic fixture.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+10
to
+14
| class Beds24PhotoSyncDiscoveryWorkflowTests(unittest.TestCase): | ||
| def test_only_secret_name_validation_is_fatal(self) -> None: | ||
| def test_only_secret_name_discovery_errors_hard_fail(self) -> None: | ||
| workflow = ( | ||
| REPOSITORY_ROOT |
Comment on lines
+1
to
+5
| { | ||
| "schema": "aumara.beds24-photo-sync-discovery", | ||
| "checked_at_utc": "2026-08-19T18:06:35Z", | ||
| "checked_at_utc": "2026-08-21T21:32:21Z", | ||
| "api_key_secret_names": [], |
Comment on lines
+6
to
+8
| "guest_name": "Maria Elvira Medina Arocas", | ||
| "first_name": "Maria Elvira", | ||
| "last_name": "Medina Arocas", |
Comment on lines
+19
to
+23
| | # | Guest | Check-in | Check-out | Nights | Unit | Beds24 / Booking | Guest inbox | | ||
| |---|---|---|---|---|---|---|---| | ||
| | 1 FIRST | Carlos Ibañez | 2026-08-02 | 2026-08-04 | 2 | Chalet | 90754013 / 6441450892 | cibane.617458@guest.booking.com | | ||
| | 2 | Luisa Nicole Martinez | 2026-08-07 | 2026-08-09 | 2 | Chalet | 91062629 / 6858847062 | 6858847062-bmf6.w8pb.mgpk.zkxh@guest.booking.com | | ||
| | 2 same weekend | Juan Ayala Moretti | 2026-08-07 | 2026-08-09 | 2 | Chalet | 91036023 / 5383433517 | 5383433517-sdda.6fpb.eae3.cdx3@guest.booking.com | |
Comment on lines
+3
to
+9
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'ops/nominalia_live_domain_mutator.py' | ||
| - '.github/workflows/nominalia-live-domain-mutate.yml' | ||
| workflow_dispatch: |
| @@ -0,0 +1 @@ | |||
| aLZ/fv5BgaH/j8vbSzLDDTNzaZVbWDRkYJWV8TeAc0uYfvCJgu0m42y2UynBuePVHlQq3v2slClnB8zTsxo35lEnOV8b6kJjcTw3BDdlupW9hQo7d/gQLXp3NYgAfDCGG+qGhcIvygEf3gwLxmkF9osDTCrYF6vV058W3+/OtmUonyQiSqmV0hReXOXhmTQZ6LzvJxpLZQwX1VhQbfEZiuSBFCrpW3SlENEKksWv+LsZ7a0wscVwU2seT0AhaFiATh/buUrHCY3qMDUTwSfz4Mmrvu2O+GmXYmwevnQs29W7pTS4jsEsXO4rXmpuMC+QKkCMPcswVraMb610f0OeT8kGHOZyc4FT+wp6egytvVHhszcob8o6RsfLQZdYTRcKZWIVENuilqTrfIdgtl4tIVH7R7pT2CCkRamxCbZiALr93Sxsw+nKHUaYzoVF6JqH8a6QIM5sbStjCQBzipT2ua/wSIfoq14hKwRHZZLQCy/tHhl3BzZj+2zO74RlfosU | |||
Comment on lines
+1
to
+3
| /** Permanent AUMARA guest keypad code while gateways are offline. */ | ||
| export const AUMARA_FIXED_GUEST_PIN = '1531'; | ||
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
https://github.com/openai/openai-cookbook/blob/9f1531d6ef7791d3acb90c9cf0066d7e0eb4e721/images/01_alti_agent_governance.png#L1
This change deletes all 522 tracked files under images/ (about 373 MB) while existing content still references them—for example, examples/partners/agentic_governance_guide/agentic_governance_cookbook.ipynb references this exact PNG. Merging the commit therefore breaks diagrams and screenshots across the published cookbook; restore these assets or update every affected reference.
AGENTS.md reference: AGENTS.md:L56-L58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,56 @@ | |||
| /** Permanent AUMARA guest keypad code while gateways are offline. */ | |||
| export const AUMARA_FIXED_GUEST_PIN = '1531'; | |||
Contributor
There was a problem hiding this comment.
When deployed locks retain this documented permanent shared code, publishing it in a public source file discloses a live physical-access credential to anyone who can read the repository. Move the PIN to an approved secret store, require it through runtime configuration, and rotate the deployed lock code because removing it from a later commit will not remove it from history.
AGENTS.md reference: AGENTS.md:L43-L44
Useful? React with 👍 / 👎.
|
|
||
| def resolve_access_token() -> tuple[str, str, str, str, list[str], str]: | ||
| """Resolve the existing credential without printing or replacing it.""" | ||
| credential = auth.get_credential() |
Contributor
There was a problem hiding this comment.
beds24_auth_check.get_credential() returns (credential, source_name), but this function treats that tuple as the credential and passes it into HTTP headers and redaction helpers, so the workflow's live read-only proof fails before ingestion whenever it has configured credentials. Unpack both values here and propagate the returned source instead of later referencing the nonexistent auth.CREDENTIAL_SOURCE; the targeted unit suite also currently errors on both token-resolution paths.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly describe the changes and the goal of this PR. Make sure the PR title summarizes the changes effectively.
Motivation
Why are these changes necessary? How do they improve the cookbook?
For new content
When contributing new content, read through our contribution guidelines, and mark the following action items as completed:
We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.