Succeeded with Issues: Update @typespec/http-client-csharp to 1.0.0-alpha.20260825.9 - #1341
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 655fb56cb1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fef3aad466
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a51bc9d9f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed7fb874ed
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…crosoft#11798) ## Summary - Preserve an accessible parameterless constructor that already exists on a generated serialization partial during API compatibility processing. - Avoid removing a visitor-customized constructor and synthesizing a replacement that delegates to a different overload. - Cover both the accessible-constructor preservation path and the existing internal-constructor replacement path. This addresses the constructor churn observed in openai/openai-dotnet#1341 when ApiCompatVersion is enabled. ## Validation - `npm run build` - `eng/scripts/Generate.ps1` - `npm test` - `npm run cop` - Focused constructor compatibility tests --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00636c74-c4f7-434a-8a70-fb0c3d221328
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f2f479da5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -13,7 +13,7 @@ public partial class ModerationInputPart | |||
| { | |||
| private protected IDictionary<string, BinaryData> _additionalBinaryDataProperties; | |||
|
|
|||
| private protected ModerationInputPart(ModerationInputPartKind kind) | |||
| public ModerationInputPart(ModerationInputPartKind kind) | |||
There was a problem hiding this comment.
When a caller uses the newly exposed constructor, for example new ModerationInputPart(ModerationInputPartKind.Text), it creates the base type without the required text payload and serializes only {"type":"text"}, producing a request the moderation endpoint will reject instead of guiding callers through CreateTextPart. This constructor was previously private protected; the same unintended exposure affects Grader, ResponseMessageAnnotation, and ComputerCallAction, so retain their non-public discriminator constructors.
Useful? React with 👍 / 👎.
dfef055 to
cd2897e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd2897e1e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb8f8ad7bd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Updated @typespec/http-client-csharp from 1.0.0-alpha.20260731.7 to 1.0.0-alpha.20260825.9 - Updated Microsoft.TypeSpec.Generator.ClientModel from 1.0.0-alpha.20260731.7 to 1.0.0-alpha.20260825.9 - Regenerated OpenAI SDK code with new generator version - Updated centrally managed package-lock.json file with new dependency versions
…perations in spec
… as previously auto generated
…n. Delete empty line changes.
2017ce7 to
a397893
Compare
3 participants
This PR automatically updates the TypeSpec HTTP client C# generator version and regenerates the SDK code.
Changes
@typespec/http-client-csharpfrom1.0.0-alpha.20260731.7to1.0.0-alpha.20260825.9Microsoft.TypeSpec.Generator.ClientModelfrom1.0.0-alpha.20260731.7to1.0.0-alpha.20260825.9Directory.Packages.propswith new generator package versionDetails
1.0.0-alpha.20260731.7→1.0.0-alpha.20260825.9Testing
Please run the existing test suites to ensure the generated code works correctly:
Notes
This PR was created automatically by the Update TypeSpec Generator Version workflow. The workflow runs weekly and when manually triggered to keep the generator version current with the latest TypeSpec improvements and fixes.
If there are any issues with the generated code, please review the TypeSpec release notes for breaking changes or new features that may require manual adjustments.
Manual Updates
Spec: Split 4 operations (speech, transcription, image edit, image generation) into non-streaming + streaming pairs using
@sharedRoute, with corresponding@@clientName/@@clientLocationentries.ApiCompatVersion: Added 2.13.0 to OpenAI.csproj, enabling
*On→*AtandUri→Urlrenames across all public types. Internal types will still adopt the new*Onand*Uripattern. Updated all test/example references accordingly.Discriminator constructors: Suppressed 4 generated public base constructors (
Grader,ModerationInputPart,ResponseMessageAnnotation,ComputerCallAction) and replaced with private protected versions to match main.Parameterless constructor fixes: With
ApiCompatVersion, parameterless constructors are no longer generated with internal hydration delegation. Overwrite with custom constructors to match previous delegation behavior.Streaming suppressions:
[CodeGenSuppress]for streaming convenience methods on AudioClient and ImageClient. Duplicate SSE enum stubs inGeneratorStubs.cs.Recording fixes: Re-record and updated
Acceptheaders in test recordings to accommodate operation splits.