Skip to content

fix(realtime): implement synchronous ReceiveUpdates - #1364

Open
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/realtime-sync-receive-updates
Open

fix(realtime): implement synchronous ReceiveUpdates#1364
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/realtime-sync-receive-updates

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary

  • implement both synchronous RealtimeSessionClient.ReceiveUpdates overloads
  • reuse the existing WebSocket receive pipeline and typed update deserialization
  • avoid synchronization-context capture in the receive path used by sync-over-async
  • add regressions for both protocol and typed synchronous enumeration

Fixes #1363.

Validation

  • dotnet test tests/OpenAI.Tests.csproj --filter FullyQualifiedName~RealtimeUnitTests --no-restore
  • 12/12 passed on .NET 8, .NET 9, and .NET 10
  • git diff --check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T07:42:56.499423Z deb5c39 PR opened
🔒 Security Review Completed 2026-09-07T07:43:59.384273Z deb5c39 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] RealtimeSessionClient.ReceiveUpdates throws NotImplementedException

1 participant