Allow opting out of streaming usage - #1365
Open
z0rimo wants to merge 2 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb654d76fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
z0rimo
marked this pull request as draft
September 7, 2026 15:14
z0rimo
marked this pull request as ready for review
September 7, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #616
Summary
This PR follows up on #616, where
stream_options.include_usagewas discussed as an optional value that is currently forced totruefor streaming chat completions.It adds a small option on
ChatCompletionOptionsto control that behavior while preserving the existing default.IncludeUsageInStreaming = truekeeps the current behavior and sendsstream_options.include_usage = true.IncludeUsageInStreaming = falsesendsstream_options.include_usage = false.IncludeUsageInStreaming = nullomitsstream_optionsfrom the request entirely.The default remains
true, so existing callers keep the current behavior.Implementation
ChatCompletionOptions.IncludeUsageInStreaming.ChatCompletionOptions.true,false, andnull.stream_options.Testing
Validated locally on all supported test target frameworks:
net8.0net9.0net10.0All per-framework test runs pass.
Targeted streaming chat tests also pass.
Design note
#616 also discussed protocol models as a possible way to address this scenario.
This PR proposes a small convenience API on
ChatCompletionOptionswhile keeping the existing behavior unchanged by default. I'm happy to adjust the API shape if a protocol-model-based approach is preferred.