Skip to content

Comments

Pass through fetch error messages in APIConnectionError#1659

Open
cnaples79 wants to merge 1 commit intoopenai:masterfrom
cnaples79:pass-error-message
Open

Pass through fetch error messages in APIConnectionError#1659
cnaples79 wants to merge 1 commit intoopenai:masterfrom
cnaples79:pass-error-message

Conversation

@cnaples79
Copy link

@cnaples79 cnaples79 commented Sep 25, 2025

Summary

  • include the underlying fetch error message when constructing APIConnectionError
  • assert the network error test surfaces the original message in addition to the error type

Rationale

Changes

  • update the retry logic to pass the error message into APIConnectionError
  • extend the streaming network error test to check the message is preserved

Fixes #1656

@cnaples79 cnaples79 requested a review from a team as a code owner September 25, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APIConnectionError does not pass message argument

1 participant