chore(deps-dev): bump @smithy/signature-v4 from 5.7.2 to 5.7.3 - #2679
Conversation
Bumps [@smithy/signature-v4](https://github.com/smithy-lang/smithy-typescript/tree/HEAD/packages/signature-v4) from 5.7.2 to 5.7.3. - [Release notes](https://github.com/smithy-lang/smithy-typescript/releases) - [Changelog](https://github.com/smithy-lang/smithy-typescript/blob/main/packages/signature-v4/CHANGELOG.md) - [Commits](https://github.com/smithy-lang/smithy-typescript/commits/@smithy/signature-v4@5.7.3/packages/signature-v4) --- updated-dependencies: - dependency-name: "@smithy/signature-v4" dependency-version: 5.7.3 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 34137508094 --repo openai/openai-node \
--name castiron-custom-code-34137508094-1 --dir /tmp/castiron-custom-code-34137508094-1
git apply --stat /tmp/castiron-custom-code-34137508094-1/custom-code.patch
cat /tmp/castiron-custom-code-34137508094-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin fdb038e21509264bcdf81741a40988dd694188b1 559fcfe888e4b8f27dfeb1cf16f41563661b2d58
python3 scripts/castiron/custom_code_report.py report \
--base fdb038e21509264bcdf81741a40988dd694188b1 \
--head 559fcfe888e4b8f27dfeb1cf16f41563661b2d58 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-559fcfe888e4
cat /tmp/castiron-custom-code-559fcfe888e4/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 559fcfe888
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| dependencies: | ||
| lightningcss: 1.33.0 | ||
| picomatch: 4.0.5 | ||
| picomatch: 4.0.7 |
There was a problem hiding this comment.
Restore Vite's unrelated picomatch resolution
For this targeted @smithy/signature-v4 bump, changing Vite's independent picomatch dependency from 4.0.5 to 4.0.7 adds unrelated toolchain behavior and review surface; the lock graph shows that the updated Smithy package instead depends only on @smithy/core, @smithy/types, and tslib. Restore this edge to 4.0.5 so the lockfile contains only the requested package and its dependency closure.
AGENTS.md reference: AGENTS.md:L150-L153
Useful? React with 👍 / 👎.
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Reviewed at 559fcfe. No blocking correctness or Node-version-policy findings. The Smithy Node >=18 requirement remains below the SDK's >=22.0.0 floor; CJS/ESM support and optional-peer isolation are preserved.
Validation: current-head CI passed, including supported-line packed-package and TypeScript 4.9/6 checks. Locally, the exact head passed frozen installation with existing supply-chain policies, a Node 24 build, and 192 focused Bedrock tests. Real credential-chain and SigV4 smoke tests passed through the public CJS/ESM entrypoints on exact Node 22.0.0, including service scopes and payload hashes.
Nonblocking scope note: the lockfile also updates Vite's picomatch edge from 4.0.5 to 4.0.7. Reviewed that development-only change; no resulting defect found.
Bumps @smithy/signature-v4 from 5.7.2 to 5.7.3.
Changelog
Sourced from @smithy/signature-v4's changelog.
Commits
e9151f3Version NPM packages (#2240)a825452chore: guard for-in loops (#2232)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)