[codex] use app mention syntax in hatch-pet#504
Conversation
|
[codex] @codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fa9ad9322
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - <absolute path> — <role> | ||
|
|
||
| Use $imagegen only. Read the base prompt and attach every listed input image. If the prompt contains brand inspiration, use it only as broad mascot-safe guidance; do not copy logos, readable marks, UI screenshots, slogans, or text. Before returning, visually check that the result is one centered full-body pet on a flat chroma background, with no text, scenery, shadows, or detached effects. | ||
| Use @imagegen only. Read the base prompt and attach every listed input image. If the prompt contains brand inspiration, use it only as broad mascot-safe guidance; do not copy logos, readable marks, UI screenshots, slogans, or text. Before returning, visually check that the result is one centered full-body pet on a flat chroma background, with no text, scenery, shadows, or detached effects. |
There was a problem hiding this comment.
$imagegen for worker invocation
This worker prompt is what the hatch flow sends to lightweight generation agents, so changing the explicit invocation to @imagegen makes normal base/row jobs depend on a mention syntax Codex does not document for skills or apps. I checked the current Codex docs: explicit skills use $, and /apps inserts app mentions as $app-slug, not @... (skills, apps); these workers may therefore never be routed to Image Gen and the hatch run can stall before producing assets. Please keep $imagegen here and in the generated manifest fields until @imagegen is actually supported.
Useful? React with 👍 / 👎.
1 participant
Summary
$imagegenreferences in the hatch-pet skill with@imagegen@imagegenin generated pet request and job metadataWhy
The hatch-pet flow still told Codex to invoke Imagegen with the legacy skill-style
$mention even though Imagegen is addressed through the app-style@mention. That left the “Try in chat” flow with stale invocation guidance and generated manifests that repeated the same stale syntax.This keeps the skill instructions and generated job metadata aligned on the current
@imagegenmention syntax.Source: https://x.com/morqon/status/2068812759085592772
Validation
python3 -m py_compile skills/.curated/hatch-pet/scripts/prepare_pet_run.pypet_request.jsonplusimagegen-jobs.jsonemit@imagegen$imagegenreferences remain underskills/.curated/hatch-pet