Validate VM file descriptors before ownership transfer#177
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 344572e104
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
|
LGTM. Could you please check linting issues |
fallintoplace
force-pushed
the
agent/validate-vm-fd
branch
from
July 14, 2026 22:08
36cbc4a to
1135bfd
Compare
fkorotkov-oai
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--vm-fdvalues during CLI parsing.F_DUPFD_CLOEXECbefore taking ownership.Why
VM::newpreviously converted the caller-supplied raw descriptor directly into aUnixDatagram. Invalid input could fail unpredictably, and dropping the VM wrapper could close a descriptor still owned by the caller. Softnet now owns only a validated duplicate.Validation
cargo fmt --all -- --checkcargo check --all-targetscargo check --target aarch64-apple-darwin --all-targetsThe repository's full test command is configured to run through
sudo -E; that runner could not authenticate in this environment, so the focused test binaries were run without the configured runner.