Block generic tool input and document idle timeouts - #112
Merged
frantic-openai merged 2 commits intoJul 20, 2026
Conversation
Summary: - Keep turn timeout semantics tied to stream inactivity and document them. - Add a regression for active stream updates versus silent turns. - Auto-answer only recognized MCP approval prompts. - Block freeform and option-based tool input instead of fabricating answers. - Remove the orphaned auto-answered dashboard event path. Rationale: - Operators rely on silence timeout to catch stuck turns without capping healthy long-running work. - Generic user-input answers can be interpreted as real operator intent; the existing blocked flow is safer and simpler. Tests: - focused app-server timeout, approval, and input-required cases - mise exec -- mix test test/symphony_elixir/app_server_test.exs - mise exec -- mix test test/symphony_elixir/orchestrator_status_test.exs - HEX_HOME=/private/tmp/symphony-hex mise exec -- make -C elixir all Co-authored-by: Codex <codex@openai.com>
Summary: - Auto-answer only requestUserInput questions with the MCP approval ID marker. - Keep generic Allow/Deny option prompts blocked for operator input. Rationale: - Option labels alone are not a safe approval discriminator; ordinary tool prompts can also offer an Allow choice. - The existing Codex MCP approval question ID distinguishes the narrow prompt shape that Symphony may continue automatically. Tests: - red/green generic Allow/Deny tool-input regression - recognized MCP approval prompt regression - mise exec -- mix test test/symphony_elixir/app_server_test.exs - HEX_HOME=/private/tmp/symphony-hex mise exec -- make -C elixir all Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Docs called turn timeout a total cap, while runtime uses silence. Generic tool-input prompts also received fabricated answers, and approval-looking option labels alone are not enough to identify MCP approval prompts.
TL;DR
Document idle timeouts and block generic tool input.
Summary
turn_timeout_msas a reset-on-update silence interval.Alternatives
Test Plan
HEX_HOME=/private/tmp/symphony-hex mise exec -- make -C elixir allmise exec -- mix test test/symphony_elixir/app_server_test.exs:619 test/symphony_elixir/app_server_test.exs:788mise exec -- mix test test/symphony_elixir/app_server_test.exs