Skip to content

Update Bonjour features#3

Open
wiomoc wants to merge 1 commit into
openairplay:masterfrom
wiomoc:patch-1
Open

Update Bonjour features#3
wiomoc wants to merge 1 commit into
openairplay:masterfrom
wiomoc:patch-1

Conversation

@wiomoc
Copy link
Copy Markdown

@wiomoc wiomoc commented Jan 24, 2022

Comment thread src/features.md
| 17|MetadataFeature0|bit 0 of MetadataFeatures. Text. |
| 18|AudioFormat1|support for audio format 1|
| 18|AudioFormat1|support for audio format 1 (PCM)|
| 19|AudioFormat2|support for audio format 2. This bit must be set for AirPlay 2 connection to work|
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ALAC

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ALAC...

Comment thread src/features.md
| 19|AudioFormat2|support for audio format 2. This bit must be set for AirPlay 2 connection to work|
| 20|AudioFormat3|support for audio format 3. This bit must be set for AirPlay 2 connection to work|
| 20|AudioFormat3|support for audio format 3 (AAC-LC). This bit must be set for AirPlay 2 connection to work|
| 21|AudioFormat4|support for audio format 4|
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAC-ELD?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ELD

@Neustradamus
Copy link
Copy Markdown

@griff, @systemcrash: What do you think?

@systemcrash
Copy link
Copy Markdown
Member

systemcrash commented Jan 29, 2022

Hi @wiomoc - thanks for your attention on this. I realize the documentation here is a bit behind the times, but it's still solid.

If you care to update your PR to reflect the content here, which has been verified as correct, then we can accept this.

I suspect 21 is ELD, although if so I have not seen it on the audio receiver yet, which makes me think it is sent with video, which the audio receiver doesn't do.

This repo, as its name suggests, regards airplay. Carplay, while having a very similar code-base, is a slightly different beast. At least flags 18 and 20 agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants