Using colorList if defined for plantgl triangle set #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradal
reviewed
Dec 15, 2025
src/openalea/widgets/plantgl.py
Outdated
| """Return a mesh from a scene""" | ||
| d = Tesselator() | ||
| indices, vertices, colors, attribute=[], [], [], [] | ||
| indices, vertices, colors, attribute, col_tri = [], [], [], [], [] |
Collaborator
There was a problem hiding this comment.
replace col_tri by color_triangles
Col_tri may means column_tri or something else.
src/openalea/widgets/plantgl.py
Outdated
| if d.discretization.colorList: # if a color list is defined, use it | ||
| col_list = d.discretization.colorList | ||
| for col in col_list: | ||
| hex_val = (col.red << 16) | (col.green << 8) | col.blue # get the hex code of rgb color |
Collaborator
There was a problem hiding this comment.
May be an external function?
pradal
approved these changes
Dec 15, 2025
pradal
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the caribu example notebook where colors are displayed by triangles and not by shape.