fix(typegen): fix missing params at path level#78
Open
Core-entin wants to merge 1 commit into
Open
Conversation
Core-entin
commented
May 28, 2026
| expect(clientOperationTypes).toMatch(`Paths.GetPetById.PathParameters`); | ||
| expect(clientOperationTypes).toMatch(`Paths.ReplacePetById.PathParameters`); | ||
| expect(clientOperationTypes).toMatch(`Paths.UpdatePetById.PathParameters`); | ||
| expect(clientOperationTypes).toMatch(`Paths.DeletePetById.PathParameters`); |
Author
There was a problem hiding this comment.
I am not so sure about this change in tests, since the new Parameters type is now longer and indented at the next line. The new type is Parameters<Paths.GetPetById.PathParameters & Paths.Pets$Id.HeaderParameters>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wish to solve an issue I have with some specs that sets their parameters at the path level instead of the operation level. The path level parameters were not included in the generated types and can't be used in the openapi client