Skip to content

Added a cache for skin filenames to improve EPG performance. #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dachaplin wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −0
Draft

Added a cache for skin filenames to improve EPG performance. #2928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff487d0
Added a cache for skin filenames to improve EPG performance.
Jun 6, 2023
3a6fd0a
Merge branch 'openatv:master' into resolveFilename-add-skin-cache
dachaplin Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/python/Tools/Directories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,20 @@
scopeFonts = defaultPaths[SCOPE_FONTS][0]
scopePlugins = defaultPaths[SCOPE_PLUGINS][0]

cachedSkinFilenames = {} # Dictionary of skin filenames already resolved.

def InitDefaultPaths():
resolveFilename(SCOPE_CONFIG)


def resolveFilename(scope, base="", path_prefix=None):
cached_filename_key = ""
if scope == SCOPE_GUISKIN:
cached_filename_key = str(path_prefix) + ":" + str(base)
cached_filename = cachedSkinFilenames.get(cached_filename_key)
if cached_filename is not None:
return cached_filename

if str(base).startswith("~%s" % sep): # You can only use the ~/ if we have a prefix directory.
if path_prefix:
base = pathjoin(path_prefix, base[2:])
Expand Down Expand Up @@ -216,6 +224,8 @@ def itemExists(resolveList, base):
path = path[len(plugins) + 1:]
if suffix is not None: # If a suffix was supplier restore it.
path = "%s:%s" % (path, suffix)
if scope == SCOPE_GUISKIN:
cachedSkinFilenames[cached_filename_key] = path
return path


Expand Down