Add rubocop linting CI #952
Conversation
Br3nda
force-pushed
the
rubocop
branch
4 times, most recently
from
f5223e8 to
0e769b1
Compare
makes a quicker turnaround on more minor issues, such as indentation.
benrfairless
left a comment
benrfairless
left a comment
There was a problem hiding this comment.
Approving this - Only thing I'm curious about is the workflow running 2.7 instead of 2.7.8. If this isn't a major issue, then please push to staging 👍
|
|
||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 2.7 |
|
|
||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 2.7 |
There was a problem hiding this comment.
| ruby-version: 2.7 | |
| ruby-version: 2.7.8 |
github-project-automation
bot
moved this from Backlog - General
to In review
in Right to Know
jamezpolley
left a comment
jamezpolley
left a comment
There was a problem hiding this comment.
I can't give meaningful review on this. There are a bunch of changes to code that don't seem to be directly related to the description.
I assume that these are things that are needed in order to make the linter pass. They seem to be mostly small things - the ones I've seen involve changing a :: to a ., changing which quote marks are used, using a different method to calculate a path etc. I can see that Ben has checked that they work as expected so I assume they're all fine.
I like the idea of having linting done automatically :)
What does this do?
automates lint checking in a GitHub workflow
Why was this needed?
makes a quicker turnaround on more minor issues, such as indentation.