Skip to content

Conversation

@benrfairless
Copy link

Relevant issue(s)

Fixes #965

What does this do?

  • Creates the confidence_intervals.rb file
  • Updates L25 to use Statistics3 instead of Statistics2

Why was this needed?

To resolve the bug in #965

Implementation notes

  • Deployment should occur on the host by running the below command as deploy: bundle exec rails themes:install

Screenshots

Nil

Notes to reviewer

This change won't make any impact in staging or test due to the number of records required to make it happen.

@benrfairless benrfairless requested a review from a team as a code owner November 25, 2025 04:52
@github-project-automation github-project-automation bot moved this to Backlog - General in Right to Know Nov 25, 2025
@benrfairless benrfairless self-assigned this Nov 25, 2025
@benrfairless benrfairless moved this from Backlog - General to In review in Right to Know Nov 25, 2025
denominator = 1 + z*z/total
return [(phat + z*z/(2*total) - offset)/denominator,
(phat + z*z/(2*total) + offset)/denominator]
end No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this code from upstream? I ask because the commit is yours, Ben, and we need to make sure we track this if we pull/branch from upstream again on the next alaveteli version

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in core is here: https://github.com/openaustralia/alaveteli/blob/production/lib/confidence_intervals.rb
It fixes this commit which only updated L1, not L25.

@Br3nda
Copy link

Br3nda commented Nov 25, 2025

if you ran bundle exec rubocop -a on that new ruby file it would probably all pass CI

@Br3nda Br3nda closed this Nov 25, 2025
auto-merge was automatically disabled November 25, 2025 05:16

Pull request was closed

@github-project-automation github-project-automation bot moved this from In review to Done in Right to Know Nov 25, 2025
@Br3nda Br3nda reopened this Nov 25, 2025
@github-project-automation github-project-automation bot moved this from Done to Ready in Right to Know Nov 25, 2025
@Br3nda
Copy link

Br3nda commented Nov 25, 2025

(oops, wrong button)

@benrfairless
Copy link
Author

if you ran bundle exec rubocop -a on that new ruby file it would probably all pass CI

I can't do that on my machine at the moment because I can't run bundle install on Ruby 2.7.8 on my Mac.

@benrfairless benrfairless merged commit 8222320 into staging Nov 26, 2025
6 of 8 checks passed
@benrfairless benrfairless deleted the bugfix-statistics branch November 26, 2025 01:36
@github-project-automation github-project-automation bot moved this from Ready to Done in Right to Know Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Unable to access /statistics page after upgrade to 0.42.0.2

3 participants