-
Notifications
You must be signed in to change notification settings - Fork 17
Add confidence_intervals.rb from core, and update it to use Statistics3 #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| denominator = 1 + z*z/total | ||
| return [(phat + z*z/(2*total) - offset)/denominator, | ||
| (phat + z*z/(2*total) + offset)/denominator] | ||
| end No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this code from upstream? I ask because the commit is yours, Ben, and we need to make sure we track this if we pull/branch from upstream again on the next alaveteli version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in core is here: https://github.com/openaustralia/alaveteli/blob/production/lib/confidence_intervals.rb
It fixes this commit which only updated L1, not L25.
|
if you ran |
|
(oops, wrong button) |
I can't do that on my machine at the moment because I can't run bundle install on Ruby 2.7.8 on my Mac. |
Relevant issue(s)
Fixes #965
What does this do?
Why was this needed?
To resolve the bug in #965
Implementation notes
bundle exec rails themes:installScreenshots
Nil
Notes to reviewer
This change won't make any impact in staging or test due to the number of records required to make it happen.