Skip to content

fix access to stopwords and alphabet#170

Merged
Br3nda merged 2 commits into
mainfrom
fix/access-to-stop-words
May 21, 2026
Merged

fix access to stopwords and alphabet#170
Br3nda merged 2 commits into
mainfrom
fix/access-to-stop-words

Conversation

@Br3nda

@Br3nda Br3nda commented May 21, 2026

Copy link
Copy Markdown
Contributor

Relevant issue(s)

What does this do?

Why was this needed?

adds getter methods for alphabet and stop words

Implementation/Deploy Steps (Optional)

errors on production:
PHP Fatal error: Uncaught Error: Cannot access private property GLOSSARY::$stopwords in /srv/www/production/releases/20260517060354/twfy/www/docs/addterm/index.php:31\nStack trace:\n#0 {main}\n thrown in /srv/www/production/releases/20260517060354/twfy/www/docs/addterm/index.php on line 31, referer: http://www.baidu.org.au/

Notes to reviewer (Optional)

@Br3nda Br3nda requested a review from a team as a code owner May 21, 2026 04:54
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions

Copy link
Copy Markdown

Code Coverage

Code Coverage Report:
  2026-05-21 04:57:39

 Summary:
  Classes:  0.00% (0/35)
  Methods:  7.08% (25/353)
  Lines:    2.58% (242/9362)

ALERT
  Methods:   7.14% ( 1/14)   Lines:   0.65% (  1/154)
GLOSSARY
  Methods:  22.22% ( 2/ 9)   Lines:   1.68% (  2/119)
MEMBER
  Methods:   0.00% ( 0/32)   Lines:   4.40% ( 17/386)
MySQL
  Methods:  66.67% ( 4/ 6)   Lines:  55.88% ( 19/ 34)
MySQLQuery
  Methods:  81.82% ( 9/11)   Lines:  85.53% ( 65/ 76)
THEUSER
  Methods:   8.33% ( 1/12)   Lines:  17.01% ( 25/147)
USER
  Methods:  28.57% ( 8/28)   Lines:  14.59% ( 41/281)

@ianheggie-oaf ianheggie-oaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - makes sense to me

@Br3nda Br3nda merged commit 04124fb into main May 21, 2026
6 of 7 checks passed
@Br3nda Br3nda deleted the fix/access-to-stop-words branch May 21, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants