Skip to content

Feature/dry#173

Merged
ianheggie-oaf merged 14 commits into
mainfrom
feature/DRY
May 22, 2026
Merged

Feature/dry#173
ianheggie-oaf merged 14 commits into
mainfrom
feature/DRY

Conversation

@Br3nda
Copy link
Copy Markdown
Contributor

@Br3nda Br3nda commented May 21, 2026

What does this do?

index.php and mobile.php contain duplicate functions. This moves them into a single copy, which they both include.

@Br3nda Br3nda requested a review from a team as a code owner May 21, 2026 20:02
Br3nda and others added 8 commits May 21, 2026 20:03
@Br3nda
Merge branch 'main' into feature/DRY
d215c5a
@Br3nda
convert to use echo, instead of closing the php tag
0486a6d 
Co-authored-by: Copilot <copilot@github.com>
@Br3nda
safer highlighted html
cd3b604 
Co-authored-by: Copilot <copilot@github.com>
@Br3nda
fix short open tag
68d970e 
Co-authored-by: Copilot <copilot@github.com>
@Br3nda
adding types
034002d 
Co-authored-by: Copilot <copilot@github.com>
@Br3nda
tests for highlited text
cc37c47
@Br3nda
lint fixes (commentary)
2fbd0d5 
Co-authored-by: Copilot <copilot@github.com>
@Br3nda
lint fixes (commentary)
a8c63d5 
Co-authored-by: Copilot <copilot@github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 21, 2026

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Code Coverage

Code Coverage Report:
  2026-05-21 20:17:43

 Summary:
  Classes:  0.00% (0/35)
  Methods:  7.08% (25/353)
  Lines:    2.61% (248/9508)

ALERT
  Methods:   7.14% ( 1/14)   Lines:   0.65% (  1/154)
GLOSSARY
  Methods:  22.22% ( 2/ 9)   Lines:   1.68% (  2/119)
MEMBER
  Methods:   0.00% ( 0/32)   Lines:   4.40% ( 17/386)
MySQL
  Methods:  66.67% ( 4/ 6)   Lines:  55.88% ( 19/ 34)
MySQLQuery
  Methods:  81.82% ( 9/11)   Lines:  85.53% ( 65/ 76)
THEUSER
  Methods:   8.33% ( 1/12)   Lines:  17.01% ( 25/147)
USER
  Methods:  28.57% ( 8/28)   Lines:  14.59% ( 41/281)

@ianheggie-oaf ianheggie-oaf added the reliability Increase reliability by reducing complexity, technical debt and increasing monitoring, robustness label May 22, 2026
ianheggie-oaf
ianheggie-oaf approved these changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ianheggie-oaf ianheggie-oaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - makes sense to me

@ianheggie-oaf
Copy link
Copy Markdown
Member

ianheggie-oaf commented May 22, 2026

@Br3nda - I also merged this so it can go in deploy

@ianheggie-oaf ianheggie-oaf merged commit 929f5af into main May 22, 2026
7 checks passed
@ianheggie-oaf ianheggie-oaf deleted the feature/DRY branch May 22, 2026 05:57
@Br3nda
Copy link
Copy Markdown
Contributor Author

Br3nda commented May 22, 2026

Thanks ian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianheggie-oaf ianheggie-oaf ianheggie-oaf approved these changes

Assignees

@Br3nda Br3nda

Labels

reliability Increase reliability by reducing complexity, technical debt and increasing monitoring, robustness

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Br3nda @ianheggie-oaf