Enabled psalm for php#193
Draft
Br3nda wants to merge 16 commits into
Draft
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
…ver referenced or the value is not used (see https://psalm.dev/077)
Error: scripts/mprss.php:27:1: UnusedVariable: $starttime is never referenced or the value is not used (see https://psalm.dev/077) Error: scripts/mprss.php:50:39: UnusedVariable: $n is never referenced or the value is not used (see https://psalm.dev/077)
Br3nda
commented
May 31, 2026
| // However, no point checking, if the user can't add terms. | ||
| if ($THEUSER->is_able_to('addterm')) { | ||
|
|
||
| $args['count'] = $GLOSSARY->hansard_count($args); |
Contributor
Author
There was a problem hiding this comment.
i went through git history and this function has never existed. There was a member variable with this name at time of CVS import in 2004, but no method.
Error: scripts/alertgonemps.php:66:13: UnusedVariable: $user_id is never referenced or the value is not used (see https://psalm.dev/077) Error: scripts/alertgonemps.php:69:13: UnusedVariable: $user_id is never referenced or the value is not used (see https://psalm.dev/077)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function check_input($details) { | ||
|
|
||
| global $ALERT, $this_page; | ||
| global $ALERT; |
| */ | ||
| public function content_start() { | ||
| global $DATA, $this_page; | ||
| global $DATA; |
| */ | ||
| public function stripe_end($contents = [], $extra = '') { | ||
| global $DATA, $this_page; | ||
| global $DATA; |
| */ | ||
| public function include_sidebar_template($sidebarname) { | ||
| global $this_page, $DATA; | ||
| global $DATA; |
| */ | ||
| public function page_footer($extra = null) { | ||
| global $DATA, $this_page; | ||
| global $DATA; |
| @@ -1,5 +1,5 @@ | |||
| <?php | |||
| global $PAGE, $DATA, $this_page; | |||
| global $PAGE, $DATA; | |||
| @@ -1,5 +1,5 @@ | |||
| <?php | |||
| global $PAGE, $DATA, $this_page; | |||
| global $PAGE, $DATA; | |||
| */ | ||
|
|
||
| global $PAGE, $this_page, $GLOSSARY; | ||
| global $PAGE, $GLOSSARY; |
| ); | ||
| */ | ||
| global $PAGE, $this_page, $DATA; | ||
| global $PAGE, $DATA; |
| ); | ||
| */ | ||
| global $PAGE, $this_page, $DATA; | ||
| global $PAGE, $DATA; |
Code Coverage |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
openaustralia/openaustralia#858
Enables psalm, which is specifically for php
What does this do?
Psalm is a free & open-source static analysis tool that helps you identify problems in your code