Skip to content

Add helper to bump tags automatically#35

Open
cipherboy wants to merge 1 commit intoopenbao:mainfrom
cipherboy:add-tag-helper
Open

Add helper to bump tags automatically#35
cipherboy wants to merge 1 commit intoopenbao:mainfrom
cipherboy:add-tag-helper

Conversation

@cipherboy
Copy link
Member

No description provided.

@@ -0,0 +1,87 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
#!/bin/bash
#!/usr/bin/env bash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a distro packaging perspective using a hardcoded path makes sense, as you want to bind the package to a version of bash you know exists and fully control. From a development utility script perspective that is not packaged and released (such as this one), dynamically resolving bash based on the user's environment makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants