Open
Conversation
Signed-off-by: Alexander Scheel <ascheel@gitlab.com>
satoqz
reviewed
Sep 30, 2025
| CipherAlgo_RSA | ||
|
|
||
| CipherAlgo_Provider_Specific_Base CipherAlgorithm = 65536 | ||
| CipherAlgo_Provider_Specific_Top CipherAlgorithm = 165536 |
Member
There was a problem hiding this comment.
Hmm, are top values necessary? Is there a concern with [base, max_int]?
Member
Author
There was a problem hiding this comment.
@satoqz I guess we can range to max_int, but I'd prefer to give us more headroom and partition halfway in that case. If we have more than 64k algorithms, that's admittedly a lot, but reserving the remaining 64k...4b for provider-specific seems unbalanced.
Thoughts?
satoqz
approved these changes
Dec 3, 2025
| KeyType_ED_Public | ||
| KeyType_ED_Private | ||
|
|
||
| KeyType_Provider_Specific_Base KeyType = 65536 |
Member
There was a problem hiding this comment.
Suggested change
| KeyType_Provider_Specific_Base KeyType = 65536 | |
| KeyType_ProviderSpecificBase KeyType = 65536 |
nit, I think we can omit the underscores here as the identifier isn't made of acronyms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to implement compatibility with Wrapper for GCP KMS which currently uses a custom algorithm.