Open
Conversation
phil9909
force-pushed
the
migrate-aws-go-sdk-v2
branch
3 times, most recently
from
6f22fc8 to
df0643f
Compare
Signed-off-by: Philipp Stehle <philipp.stehle@secretz.io>
This avoids awsutil trying to autodetect the region based on ec2 metadata (which will fail, if you don't have proper AWS credentials configured) Signed-off-by: Philipp Stehle <philipp.stehle@secretz.io>
phil9909
force-pushed
the
migrate-aws-go-sdk-v2
branch
from
df0643f to
61882b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to running the acceptance tests, I also tested
Decryptof an value I encrypted with the code in main.we have to create our own
KMSAPIinterface, because: