coreneuron: test reports (mostly compartment and summation) - #337
Merged
Conversation
Use BaseCell.get_sec in ngv
WeinaJi
reviewed
Aug 28, 2025
WeinaJi
reviewed
Sep 1, 2025
WeinaJi
reviewed
Sep 3, 2025
WeinaJi
reviewed
Sep 4, 2025
WeinaJi
left a comment
WeinaJi
left a comment
Collaborator
There was a problem hiding this comment.
I've reviewed the tests. They look good. Just a nitpick regarding error msgs checks.
WeinaJi
reviewed
Sep 4, 2025
WeinaJi
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This should finally take care of the compartment sets for coreneuron
Fix: #345 #322
testing for:
neuronsimulator/nrn#3507
neuronsimulator/nrn#3542
Scope
_report_setup)CoreReportConfigto finally handle in a proper wayreport.confwrite_sim_config,update_report_conf,write_report_confand similar functions inCoreConfig. UseCoreSimulationConfigandCoreReportConfiginsteadcell-permutein another issue/pr. EDIT done: investigatecell-permute#367report_parameters.pyCumulativeErrormoved inpyutilsReportParamsnow has its own file alleviating the burden of thenode.pyfile._report_build_params(previously innode.py) is also inside the new file.target_typeis no more. We do not need encoding/decoding. We just writesectionsandcompartmentsin thereport.confenable_reports. It is still a complex function but it should be easier to read and with less edge cases@cache_errorsto just fill aCumulativeErrorinstead of raising an error and raise it at the endmerge_dicts(intests/utils.py) allows for overrides and suppression of sections from the child dict with the special keywords:override_fieldanddelete_fieldreport.confchangestype_namehas been split intosectionsandcompartments. No need to encode everything in an enum to decode later. This simplifies code and makes thereport.conf. The code is slightly slower0(1)in a part of the code that was not performance-criticalscalingadded at the end of the report line (after buffer size)compartment_set. Having them when it is not or not having them when it is is an error.Testing
test_reports.pyTesting