Skip to content

SonataConfig.parsedModifications rework#461

Merged
cattabiani merged 8 commits intomainfrom
katta/modifications_rework_and_bug_fix
Feb 6, 2026
Merged

SonataConfig.parsedModifications rework#461
cattabiani merged 8 commits intomainfrom
katta/modifications_rework_and_bug_fix

Conversation

@cattabiani
Copy link
Contributor

@cattabiani cattabiani commented Jan 7, 2026

Context

modifications is now a list of dicts

Fix: #458
Fix: #460
Fix: #462

Scope

  • make modifications a list
  • remove validator: it was validating just stuff coming from libsonata. Libsonata has the fields by construction
  • adapt configuration and tests
  • register modification types using an enum, not the name of the class

Testing

@cattabiani cattabiani changed the title rework modifications modifications: rework Jan 7, 2026
@cattabiani cattabiani force-pushed the katta/modifications_rework_and_bug_fix branch from 3676bf2 to b7b91b2 Compare January 7, 2026 15:17
@cattabiani cattabiani requested review from WeinaJi and mgeplf January 7, 2026 15:20
@cattabiani cattabiani self-assigned this Jan 7, 2026
@cattabiani cattabiani marked this pull request as ready for review January 7, 2026 15:20
@cattabiani cattabiani changed the title modifications: rework modifications rework Jan 8, 2026
@cattabiani cattabiani changed the title modifications rework parsedModifications rework Jan 8, 2026
@cattabiani cattabiani changed the title parsedModifications rework SonataConfig.parsedModifications rework Jan 8, 2026
jamesgking
jamesgking previously approved these changes Jan 9, 2026
Copy link
Collaborator

@jamesgking jamesgking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cattabiani cattabiani force-pushed the katta/modifications_rework_and_bug_fix branch from b7b91b2 to 5db48f0 Compare January 9, 2026 10:58
Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, a small nit but not a required change on my end.
I'll let @WeinaJi make her checks.

Copy link
Collaborator

@WeinaJi WeinaJi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@cattabiani cattabiani merged commit de628b8 into main Feb 6, 2026
19 checks passed
@cattabiani cattabiani deleted the katta/modifications_rework_and_bug_fix branch February 6, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants