Skip to content

Conversation

@jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Jul 31, 2024

Disabling all rules except for the passing ones leaves us with green CI even if we check all files. Contributors will no longer be forced to reformat every changed file, making diffs more readable. The disabled rules can be fixed and enabled one by one in follow-up PRs.

@jrmajor jrmajor force-pushed the php-cs-fixer-config branch from fc71602 to d7693e6 Compare July 31, 2024 22:27
@jrmajor jrmajor marked this pull request as ready for review August 3, 2024 22:11
@jrmajor
Copy link
Contributor Author

jrmajor commented Aug 3, 2024

Couldn't get the workflow to run on this PR. Maybe it will only run on PRs after it's merged? Seems like it ran in my fork: https://github.com/jrmajor/opencaching-pl/commits/php-cs-fixer-config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant