This repository was archived by the owner on Apr 16, 2025. It is now read-only.
Updated int test README file#154
Open
andamian wants to merge 8 commits intoopencadc:mainfrom
Open
Conversation
pdowler
suggested changes
Dec 6, 2024
| - `haproxy` (image: `cadc-haproxy-dev`) - for https termination | ||
| - `postgress` (`cadc-postgresql-dev`) - database container | ||
| - `reg` (`reg`) - local registry entries | ||
| - `icewind` (`icewind`) - to create the `caom2` schema and tables |
Member
There was a problem hiding this comment.
technically, one can use icewind to create the caom2 tables and add some content OR deploy torkeep to just create the tables
I do not recall if the tests will all pass when the tables are empty, but they should. The tests would not hit all possible code paths, but that's going to be true with real content and would not be completely thorough unless we specify some specific test content (a handful of observations with all possible fields filled in).
| ca.nrc.cadc.reg.client.RegistryClient.host=<name of local host> | ||
| # database connection pools | ||
| # tapadm - assuming pgdev:5432 is where the database is deployed | ||
| org.opencadc.argus.tapadm.maxActive=2 |
Member
There was a problem hiding this comment.
testing should always use pool size of 1 for all pools
I never put the PG port number in JDBC URLs since we always run on the default port. Better to omit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.