Merged
Conversation
- Timestamp field respects arraysize. - Arraysize=1 is ignored to be single letter field instead of an array.
pdowler
requested changes
Jan 20, 2026
cadc-dali/src/main/java/ca/nrc/cadc/dali/util/UTCTimestampFormat.java
Outdated
Show resolved
Hide resolved
pdowler
requested changes
Jan 26, 2026
| // arraysize = null/0 and isVariable = null/true indicates * (no limit) | ||
| public UTCTimestampFormat(Integer arraysize, Boolean isVariable) { | ||
| if (isVariable == null) { | ||
| this.isVariable = isVariable = true; |
Member
There was a problem hiding this comment.
something odd here; should be false??
cadc-dali/src/main/java/ca/nrc/cadc/dali/util/UTCTimestampFormat.java
Outdated
Show resolved
Hide resolved
pdowler
requested changes
Jan 29, 2026
cadc-dali/src/main/java/ca/nrc/cadc/dali/util/UTCTimestampFormat.java
Outdated
Show resolved
Hide resolved
pdowler
requested changes
Feb 3, 2026
Member
pdowler
left a comment
pdowler
left a comment
There was a problem hiding this comment.
Just missing a version update in cadc-dali-parquet/build.gradle
pdowler
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CADC-14941 - VOTable and arraysize=1
CADC-14950 - cadc-dali: improve UTCTimeStampFormat to respect arraysize