Skip to content

Remove filter selection if no value is selected #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eduardklinger
Copy link

@eduardklinger eduardklinger commented Mar 1, 2025

When a filter was selected, but no value was chosen, the filter dropdown or datepicker was unexpectedly opening on a page reload.

This fixes this issue including #1079

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Hi @eduardklinger
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

I'm told that @eduardklinger has already filed his CLA, but is not currently on the list at https://licensing.apereo.org/. This can take some time, so reviewer can ignore the bot here.

@eduardklinger if you file any other PRs you're going to see other messages like this. Ping me or @lkiesow and we'll get to removing them.

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1132

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1132

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Mar 1, 2025

This pull request is deployed at test.admin-interface.opencast.org/1132/2025-03-01_14-37-25/ .
It might take a few minutes for it to become available.

@geichelberger geichelberger added the type:bug Something isn't working label Mar 1, 2025
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to somehow break the feature where we remember set filters across tab switches (see #980).

@opencast opencast deleted a comment from github-actions bot Mar 11, 2025
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants