Make wizard stepping more robust #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the code surrounding the wizard stepper (the circle at the top of e.g. the create event modal) to rely on string literals instead of indices. This should make it harder to accidentally break anything when making changes to the code. Also fixes web console errors pertaining to "React.Fragment" in the WizardStepper component (did not cause any functional errors). Also fixes opencast#1098.
Arnei
added
type:bug
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1169/2025-05-14_07-27-11/ . |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
JamesUoM
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the code surrounding the wizard stepper (the circle at the top of e.g. the create event modal1) to rely on string literals instead of indices. This should make it harder to accidentally break anything when making changes to the code.
Also fixes web console errors "Invalid prop
indexsupplied toReact.Fragment." in the WizardStepper component (they did not cause any functional errors).Also fixes #1098.
How to test this
Can be tested as usual. Check that modal navigation in every modal where the wizard stepper is used still functions as expected, especially that the user cannot skip any steps they are not supposed to.
(1 The Wizard Stepper)
