Skip to content

Show service online status #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Apr 8, 2025

Requires opencast/opencast#6632 to function.

Fixes #1166.

Adds a column to the services table that displays the online status of a service using traffic lights, much like the respective column in the servers table.
This change should make it easier to reason about why certain jobs may not able to be dispatched.

Notably, an offline service does not necessarily mean that there is an error or even a problem. Therefore this patch does not add a notification about services being offline.

Bildschirmfoto vom 2025-04-08 12-04-43

How to test this

Adds a column to the services table that displays the online
status of a service using traffic lights, much like the
respective column in the servers table.
This change should make it easier to reason about why
certain jobs may not able to be dispatched.

Notably, an offline service does not necessarily mean that
there is an error or even a problem. Therefore this patch
does not add a notification about services
being offline.

Requires opencast/opencast#6632 to function.
@Arnei Arnei added the type:enhancement New feature or request label Apr 8, 2025
@Arnei Arnei requested a review from KatrinIhler April 8, 2025 10:15
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1178

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1178

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

This pull request is deployed at test.admin-interface.opencast.org/1178/2025-04-08_10-15-59/ .
It might take a few minutes for it to become available.

@gregorydlogan
Copy link
Member

For easier testing, even on an all in one set heartbeat.interval=0 in org.opencastproject.serviceregistry.impl.ServiceRegistryJpaImpl.cfg, then use update oc_host_registration set online=0; and/or update oc_host_registration set maintenance=1; to make hosts be offline and/or in maintenance.

This is really nitpicky, but should we center the traffic light? I feel like it looks odd being that far over, even though everything else is left adjusted.

As is Centered
image image

@Arnei
Copy link
Member Author

Arnei commented Apr 14, 2025

This is really nitpicky, but should we center the traffic light? I feel like it looks odd being that far over, even though everything else is left adjusted.

I'm slightly in favor of keeping it left, just because that keeps it the same as the other columns and does not make it look so lost in case the column is wider than min-width. But I also do not care all that much.

Copy link
Contributor

@wsmirnow wsmirnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@gregorydlogan
Copy link
Member

Fine by me

@gregorydlogan gregorydlogan self-assigned this May 14, 2025
@gregorydlogan gregorydlogan merged commit 0b18f03 into opencast:main May 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show when a service is offline
3 participants