-
Notifications
You must be signed in to change notification settings - Fork 39
Replace MUI-datepicker with react-datepicker in the statistics component #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MUI-datepicker with react-datepicker in the statistics component #1185
Conversation
This will allow us to remove the MUI-datepicker dependency from the admin ui.
All instances of the MUI-datepicker were replaced by the react-datepicker. So the MUI-datepicker dependency can be removed completely. Also removed stuff that was necessary for localizing the MUI datepicker and old datepicker styling.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1185/2025-05-14_15-15-39/ . |
|
This pull request has conflicts ☹ |
|
Sorry I didn't see this, as I've updated the MUI dependency #1248 and caused you a merge conflict |
Arnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and code looks reasonable to me. Yay, no more mui datepickers!
Small nitpicks below.
This PR continues the work started in #986 and replaces the last occurrence of the MUI-datepicker (in the time series statistics component) with the react-datepicker.
At the same time, the MUI datepicker dependency is completely removed, including the old localization and styling stuff.
Addresses the issue #614 about unifying the date picker throughout the admin UI.
In order to be able to test these changes, the Opencast Statistics feature needs to be enabled and configured.