Skip to content

Conversation

@snoesberger
Copy link
Contributor

This PR continues the work started in #986 and replaces the last occurrence of the MUI-datepicker (in the time series statistics component) with the react-datepicker.
At the same time, the MUI datepicker dependency is completely removed, including the old localization and styling stuff.

Addresses the issue #614 about unifying the date picker throughout the admin UI.

In order to be able to test these changes, the Opencast Statistics feature needs to be enabled and configured.

This will allow us to remove the MUI-datepicker dependency from the admin ui.
All instances of the MUI-datepicker were replaced by the react-datepicker.
So the MUI-datepicker dependency can be removed completely.
Also removed stuff that was necessary for localizing the MUI datepicker and
old datepicker styling.
@github-actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1185

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1185

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

This pull request is deployed at test.admin-interface.opencast.org/1185/2025-05-14_15-15-39/ .
It might take a few minutes for it to become available.

@snoesberger snoesberger added type:code-enhancement Internal improvements to the codebase type:visual-clarity Improves UI readability labels Apr 25, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@JamesUoM
Copy link
Contributor

Sorry I didn't see this, as I've updated the MUI dependency #1248 and caused you a merge conflict

@Arnei Arnei self-requested a review May 14, 2025 13:55
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and code looks reasonable to me. Yay, no more mui datepickers!

Small nitpicks below.

@snoesberger snoesberger requested a review from Arnei May 14, 2025 15:19
@Arnei Arnei merged commit 79e0c94 into opencast:main May 15, 2025
5 checks passed
@snoesberger snoesberger self-assigned this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:low type:code-enhancement Internal improvements to the codebase type:visual-clarity Improves UI readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants