Skip to content

Fix tooltip text #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix tooltip text #1200

wants to merge 11 commits into from

Conversation

priya-tik
Copy link

This PR fixes incorrect tooltips on delete buttons across the Users, Groups, and Access Policies tabs.
The tooltip previously said "Open details", which was misleading. Now it shows "Delete user", "Delete group", etc., as appropriate.

Copy link
Contributor

github-actions bot commented May 8, 2025

Hi @priya-tik
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Copy link
Contributor

github-actions bot commented May 8, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1200

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1200

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented May 8, 2025

This pull request is deployed at test.admin-interface.opencast.org/1200/2025-05-17_05-35-37/ .
It might take a few minutes for it to become available.

@priya-tik
Copy link
Author

@Arnei Could you please add the label "type:visual-clarity" or "type:usability" so the PR passes the label check?

@Arnei Arnei added the type:bug Something isn't working label May 8, 2025
@Arnei
Copy link
Member

Arnei commented May 8, 2025

Note: #1184 seems to address the same issue.

@priya-tik
Copy link
Author

Note: #1184 seems to address the same issue.

yes, but i dont think it got closed thats why i resloved it

Note: #1184 seems to address the same issue.

@Arnei
Copy link
Member

Arnei commented May 8, 2025

#1184 is not closed, as can be seen by the green "Open" label under the title. Furthermore, a PR being open for a couple weeks also does not imply that the PR is closed or unwanted.

@priya-tik
Copy link
Author

#1184 is not closed, as can be seen by the green "Open" label under the title. Furthermore, a PR being open for a couple weeks also does not imply that the PR is closed or unwanted.

ok

@Arnei
Copy link
Member

Arnei commented May 13, 2025

Please make sure your git history is clean and that each PR only contains the commits that are relevant to the issue you are solving. For example, this PR also contains commits that are used to solve #1197. This PR should not contain those commits, unless there is a good reason for it.

@stefanosgeo stefanosgeo requested review from stefanosgeo and removed request for stefanosgeo May 13, 2025 14:28
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Merge upstream/main into fix/tooltip-text

- Resolved package.json and package-lock.json conflicts
- Updated dependencies to match upstream
@NadiaUoM
Copy link
Contributor

@Arnei : I think we should close this PR as the changes for this issue has been already merged...

#1184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants