Skip to content

Add/Edit user dialog: aligned roles #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Janni2006
Copy link
Contributor

This PR fixes #1264

The roles view is now alligned as descriped in the issue inspired by the possible solution.
image

Copy link
Contributor

Hi @Janni2006
Thank you for contributing to the Opencast Admin UI.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1280

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1280

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1280/2025-05-14_12-30-45/ .
It might take a few minutes for it to become available.

@Arnei Arnei added the type:visual-clarity Improves UI readability label May 14, 2025
@Arnei Arnei self-requested a review May 14, 2025 12:42
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header "selected roles" is in the wrong place. There currently also is a lot of wasted space:

Bildschirmfoto vom 2025-05-14 14-47-31

@Janni2006
Copy link
Contributor Author

@Arnei I couln´t recreate the issue with the header being in the wrong place. Do you have an idea on how I could replicate the issue?

As for the wasted space, do you have a suggestion on what could be moved?

@Arnei
Copy link
Member

Arnei commented May 22, 2025

I am using Firefox 137 under Fedora.

The cause might be due to a wrong CSS class being applied? Deactiving width: 47% seems to fix it for me.
Bildschirmfoto vom 2025-05-22 17-11-01

Regarding the wasted space, maybe have the right box start where it was originally starting, but have it stretch down so that the bottoms of both the left and right box are aligned? Might be a good compromise between alignment and using space effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add User Dialog: Roles view is unaligned
2 participants