Make required metadata fields more visible #1566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metadata validation for dropdowns was no working, this should help.
Validation for the metadata form was ignored for the initial metadata values. This fixes that.
Mark required metadata fields with a "*" like in the admin ui. This does not change any functionality.
Instead of returning only one validation function per field, allow returning multiple functions . For example, "duration" may be required but should also be formatted correctly.
Arnei
added
type:bug
|
This pull request is deployed at test.editor.opencast.org/1566/2025-03-31_15-16-12/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #1565.
Overall this PR aims at making the user more aware of required fields in the metadata tab, particularly if one of those required fields is missing a value which will result in an error in the backend. The individual changes can be found in the commit history.
Does not prevent the user from clicking "Save & Process" even if there are still validation issues. Would like to add that in a different PR as a more generalized version of #1517.
How to test this
Ideally this is tested with an Opencast you can control, so you can change which metadata fields are required in
etc/org.opencastproject.ui.metadata.CatalogUIAdapterFactory-episode-common.cfg.