Skip to content

Conversation

@ckaminer
Copy link
Contributor

No description provided.

@azuser
Copy link
Contributor

azuser commented Dec 16, 2020

It would be great to add a readme file with different type you used.

@ckaminer
Copy link
Contributor Author

It would be great to add a readme file with different type you used.

All set 👍

@@ -0,0 +1,16 @@
id,name
ocd-division/country:be,Belgium
ocd-division/country:be/region:be,Brussels-Capital
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also appear to be Flanders and Wallonia as the other two regions. If we're including one we should include the other two.

https://en.wikipedia.org/wiki/Communities,_regions_and_language_areas_of_Belgium#Regions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'm having a hard time determining what the abbreviations should be. Right now I have region:fl and region:wa but please correct me if those are wrong. I also have a related question: upon reading the Wikipedia page you linked above it looks like all of the ten provinces either belong to the Flanders or Wallonia regions. Should those IDs have the region included before the province? For example ocd-division/country:be/region:fl/province:an instead of ocd-division/country:be/province:an

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants