-
Notifications
You must be signed in to change notification settings - Fork 95
additions to AL, CA, CO, KS, LA, MA, MS, MT, NE, NM, NV, OH, TX, and … #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…UT local gov, US state courts, and US territories
jloutsenhizer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through and checked the district counts looked correct based on a quick search for each set added.
Left comments for a few small issues I noticed.
…tate-ms-local_gov.csv, state-nm-local_gov.csv
…tate-ms-local_gov.csv, state-nm-local_gov.csv
|
Hi, I went to check for new updates and noticed that these have not yet been merged. Are there outstanding conflicts on my end? Thanks. |
|
Nothing blocking from your end, we just need a second review. @jpmckinney or @HKSenior can you take a look? |
| @@ -1,3 +1,13 @@ | |||
| ocd-division/country:us/state:ks/board_of_education:1,Kansas State Board of Education District 1 | |||
| ocd-division/country:us/state:ks/board_of_education:10,Kansas State Board of Education District 10 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: lets move this to the bottom of this change set to keep things ordered.
jpmckinney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a baby two months ago, so I'm just taking a very quick look. LGTM. Some nitpicks are the ordering (existing comment) and I think the last newline was deleted from a couple files.
additions to AL, CA, CO, KS, LA, MA, MS, MT, NE, NM, NV, OH, TX, and UT local gov, US state courts, and US territories