-
Notifications
You must be signed in to change notification settings - Fork 95
Add new HK functional constituencies to identifiers #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new HK functional constituencies to identifiers #420
Conversation
Added 'District Council (Third)' and 'HKSAR members of NPC and CPPCC, representatives of national organisations' to country-hk.csv and functional_constituencies.csv with start date 2021-12-19.
| ocd-division/country:hk/functional_constituency:catering,Catering,, | ||
| ocd-division/country:hk/functional_constituency:district_council_first,District Council (First),, | ||
| ocd-division/country:hk/functional_constituency:district_council_second,District Council (Second),, | ||
| ocd-division/country:hk/functional_constituency:district_council_third,District Council (Third),,2021-12-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked documentation refers to a third Commercial functional constituency, but this is adding a District Council of which there only appears to be two? Should the update be for ocd-division/country:hk/functional_constituency:commercial_third in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
yes, you're right, it should be ocd-division/country:hk/functional_constituency:commercial_third, I've replaced it with correct one. Thanks for pointing out the mistake. Sorry!
Replaces 'District Council (Third)' with 'Commercial (Third)' in both country-hk.csv and functional_constituencies.csv, reflecting changes to the list of functional constituencies for Hong Kong.
| ocd-division/country:hk/functional_constituency:catering,Catering,, | ||
| ocd-division/country:hk/functional_constituency:district_council_first,District Council (First),, | ||
| ocd-division/country:hk/functional_constituency:district_council_second,District Council (Second),, | ||
| ocd-division/country:hk/functional_constituency:commercial_third,Commercial (Third),,2021-12-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For maintenance purposes can this line be added adjacent to the other commercial districts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
this row has been moved higher
Moved commercial_third in functional_const
|
Tagging in @jloutsenhizer and @jpmckinney for approvals when able. |
|
Hello, Thank you! |
Hello,
Added 'District Council (Third)' and 'HKSAR members of NPC and CPPCC, representatives of national organisations' to country-hk.csv and functional_constituencies.csv with start date 2021-12-19.
Some background:
New Constituencies:
ocd-division/country:hk/functional_constituency:district_council_third
Valid from: 2021-12-19
There is an existing LegCo member in that district.
https://www.voterregistration.gov.hk/eng/statistic20213.html
From official LegCo site - https://www.legco.gov.hk/en/members/legco-members/member.html?id=265
Wikipedia page reference ; https://en.wikipedia.org/wiki/Commercial_(Third)
ocd-division/country:hk/functional_constituency:HKSAR_NPC_CPPCC_NATO
Valid from: 2021-12-19
Sources:
https://www.voterregistration.gov.hk/eng/statistic20213.html
https://www.hklii.hk/eng/hk/legis/ord/542/s20ZD.html
https://en.wikipedia.org/wiki/HKSAR_members_of_NPC_and_CPPCC,_representatives_of_national_organisations_(constituency)