docs: document SwiftLint and SwiftFormat prerequisites - #299
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 30, 2026, 10:34 AM ET / 14:34 UTC. ClawSweeper reviewWhat this changesAdds SwiftLint and SwiftFormat, with the Homebrew installation command, to the source-build prerequisites in the build guide. Merge readinessKeep open for ordinary maintainer review: this is a narrow docs-only candidate fix for the still-open linked report, and its one-line prerequisite clarification matches the repository’s documented validation workflow. Likely related people: steipete is a low-confidence adjacent repository-policy contact; the direct source-history ownership trail was not available in the supplied review evidence. Priority: P3 Review scores
Verification
How this fits togetherThe source-build guide tells developers which local tools they need before using Peekaboo’s pnpm validation helpers. Those prerequisites affect whether lint and formatting commands can run successfully after checkout. flowchart LR
A[Developer checks out source] --> B[Source-build guide]
B --> C[Install prerequisites]
C --> D[pnpm validation helpers]
D --> E[Lint and format checks]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Merge the focused build-guide correction if maintainer review agrees, so source builders see the validation-tool prerequisites before running the documented pnpm checks. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR documents an existing development prerequisite rather than repairing a runtime failure path; the linked report supplies the setup gap it addresses. Is this the best way to solve the issue? Yes: placing the missing tools beside the existing source-build prerequisites is the narrowest maintainable solution and avoids changing validation scripts or configuration. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 8448599ab899. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (4 earlier review cycles)
|
Closes #294
What Problem This Solves
Fixes an issue where users building Peekaboo from source could miss that the repository validation helpers require SwiftLint and SwiftFormat.
Why This Change Was Made
The build guide already lists the source-build prerequisites, so this adds the missing formatter and linter tools there with the Homebrew install command. This is intentionally documentation-only and does not change build scripts, lint configuration, or release behavior.
User Impact
Developers following the source-build guide can install the expected validation tools before running the pnpm helper scripts, avoiding avoidable setup failures.
Evidence
node scripts/docs-lint.mjsdocs-lint: okgit diff --checkDisclosure: AI was used to understand the codebase and review the fix.