feat: add private following inbox - #3293
Conversation
|
@giodl73-repo is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel. A member of the Team first needs to authorize it. |
97ef643 to
453ebb4
Compare
994b30c to
8e9b378
Compare
8e9b378 to
cdf35e2
Compare
cdf35e2 to
7e662bf
Compare
|
Codex review: needs real behavior proof before merge. Reviewed August 5, 2026, 4:38 AM ET / 08:38 UTC. ClawSweeper reviewWhat this changesThis draft adds a private signed-in Inbox for grouped releases from followed publishers, including read state, mute controls, cleanup, and account-menu navigation. Merge readiness⛔ Blocked until real behavior proof is added - 13 items remain Keep open: current main and v0.23.3 do not contain this Inbox feature, but the draft remains blocked by a deploy-breaking index rollout, follow-visibility defects, open stacked prerequisites, and missing real behavior proof. Priority: P3 Review scores
Verification
How this fits togetherClawHub records publisher releases and private follow preferences in Convex, then projects grouped activity into a signed-in Inbox page. The Inbox lets users review release groups and update notification and read state without exposing the follow graph publicly. flowchart LR
A[Publisher releases] --> B[Grouped publisher activity]
C[Private follow preferences] --> B
B --> D[Inbox projection]
E[Signed-in account] --> D
D --> F[Inbox page]
F --> G[Read and mute controls]
Decision needed
Why: This adds a new account-facing notification surface, private preference model, and durable activity storage; correctness repairs alone cannot establish whether that product scope should ship. Before merge
Findings
Agent review detailsSecurityNeeds attention: The authenticated follow endpoints are scoped to the caller, but their incomplete visibility check can retain and return an otherwise hidden personal publisher. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land a maintainer-sponsored, rebased Inbox stack only after a staged package-index rollout, canonical visibility and self-follow enforcement, focused regression coverage, and redacted authenticated browser proof. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: this is new behavior, and the contributor has not supplied a real authenticated run of the resulting feature. Is this the best way to solve the issue? No: the overall approach is plausible, but the direct index rollout and follow-visibility rules are not safe as submitted, and the stacked feature lacks live proof. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 459caf625079. LabelsLabel justifications:
EvidenceSecurity concerns:
What I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (6 earlier review cycles)
|
|
This pull request has been automatically marked as stale due to inactivity. |
Summary
Product shape
This follows GitHub Notifications' inbox-first UX while preserving the Facebook/X-style option: Inbox and a future chronological Following page are two projections over the same grouped publisher activity. No second store or migration is required to add the Following surface later.
ClawHub account activity remains distinct from OpenClaw's local Updates experience for installed or watched artifacts.
Stack
Depends on #2958, #2950, and #2948. This branch is commit-stacked because cross-fork PRs cannot select another fork branch as their base. Keep this PR draft until those dependencies land and the branch can be rebased to a narrow diff.
Validation
git diff --checkpass