chore(deps-dev): bump jsdom from 29.1.1 to 30.0.1 - #3412
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex review: needs changes before merge. Reviewed August 11, 2026, 2:03 PM ET / 18:03 UTC. ClawSweeper reviewWhat this changesThe PR upgrades the development-only jsdom test environment from 29.1.1 to 30.0.1 and refreshes Bun’s resolved dependency graph. Merge readiness⛔ Blocked by patch quality or review findings - 7 items remain Keep open: the refreshed branch still removes the recorded SHA-512 digest for the unchanged Carapace Git dependency, so the jsdom-only update is not safe to merge yet. Priority: P2 Review scores
Verification
How this fits togetherClawHub’s Vitest suite uses jsdom to emulate browser APIs for frontend tests. Bun resolves that test dependency graph from package.json and bun.lock before CI runs the suite. flowchart LR
A[Package manifest] --> B[Bun lockfile]
B --> C[Installed test dependencies]
C --> D[Vitest jsdom environment]
D --> E[Frontend tests]
Before merge
Findings
Agent review detailsSecurityNeeds attention: The lockfile diff weakens recorded verification metadata for an unchanged Git dependency. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the jsdom upgrade narrow by restoring the unchanged Carapace digest, then attach a redacted successful frozen-install and jsdom-backed test run before merge. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a dependency-maintenance PR, not a reported product failure. Is this the best way to solve the issue? No: the jsdom update is a reasonable path, but the unrelated deletion of existing Carapace integrity metadata must be reversed first. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against e29b59c7eb22. LabelsLabel changes:
Label justifications:
EvidenceSecurity concerns:
Acceptance criteria:
What I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
Bumps [jsdom](https://github.com/jsdom/jsdom) from 29.1.1 to 30.0.1. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.1.1...v30.0.1) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
e2ac22a to
a30aeac
Compare
Bumps jsdom from 29.1.1 to 30.0.1.
Release notes
Sourced from jsdom's releases.
Commits
658448530.0.10c51df6Update dependencies and dev dependencies32adb34Bump@asamuzakjp/dom-selector70f014aSpeed up range operations on large documents250d7eePartially fix getComputedStyle with calc()20a01fc30.0.08c8e583Precompute WPT expectation matchesf32245cBump Node.js floor and dependencies03ef23bAdd background-position longhandsded056fTest CSS.escape() with numeric IDs