refactor: attachment output flow + timezone helpers#252
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e824cd83f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if err := f.Close(); err != nil { | ||
| return err | ||
| } | ||
| return os.Rename(tmp, outPath) |
There was a problem hiding this comment.
Using os.Rename(tmp, outPath) here changes behavior for symlink outputs: when outPath is a symlink and a cache miss triggers a write, the rename replaces the symlink entry itself instead of updating the symlink target file. In practice, gmail attachment --out <symlink> will silently delete the link and leave the original target stale, whereas the previous os.WriteFile path followed symlinks; this is a user-visible regression for link-based download locations.
Useful? React with 👍 / 👎.
* refactor(gmail): simplify attachment output + cache flow * refactor(calendar): extract timezone helpers * refactor(gmail): simplify attachment output + cache flow
1 participant
Refactor only. No behavior changes intended.
Test: make ci