fix(cli): make help and output modes predictable#759
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 11, 2026, 7:06 PM ET / 23:06 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 02291d290e87. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7485e4745d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| out = append(out, args[i+1:]...) | ||
| out = append(out, "--help") |
There was a problem hiding this comment.
Do not append help after malformed command flags
When a user runs a Git-style help command with a partial or malformed flag, e.g. gog help drive ls --max nope or gog help send --body, this rewrite preserves those tokens before the synthetic --help. Kong will parse/validate them first, or may consume --help as the missing flag value, so this path can error or enter command validation instead of reliably showing help. This makes gog help <command> less robust than the new gog <command> --help truncation; drop trailing non-path arguments or insert the help flag before them.
Useful? React with 👍 / 👎.
Summary
Verification
make cimake docs-checkNo live Google API calls are required; these changes affect local parsing, help, output-mode validation, and generated metadata.